Change in vdsm[master]: hook: ovs: report network iface expeted by engine

phoracek at redhat.com phoracek at redhat.com
Mon Apr 11 10:25:21 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: hook: ovs: report network iface expeted by engine
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/55892/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 88:         ports.append(assigned_vlan)
Line 89:     return ports
Line 90: 
Line 91: 
Line 92: def networks_caps(running_config):
> The only thing that bugs me here is that mix between the actual info and th
In the native implementation we will do it in two steps. I did not expect this code to grow so much in terms of faking. However, we need quick fix to be able to test OVS code, I'd prefer to not waste more time than necessary here.
Line 93: 
Line 94:     def get_engine_expected_top_dev(net, attrs):
Line 95:         """Return top device (iface) expected by Engine."""
Line 96:         nic_bond = attrs.get('bonding') or attrs.get('nic')


Line 91: 
Line 92: def networks_caps(running_config):
Line 93: 
Line 94:     def get_engine_expected_top_dev(net, attrs):
Line 95:         """Return top device (iface) expected by Engine."""
> shameless plug: https://gerrit.ovirt.org/#/c/55323/
if you won't mind, i'd use your code with native, but now let's do it stupid (and have less work with backporting)
Line 96:         nic_bond = attrs.get('bonding') or attrs.get('nic')
Line 97:         vlan = attrs.get('vlan')
Line 98:         return (net if attrs.get('bridged', True)
Line 99:                 else '%s.%s' % (nic_bond, vlan) if vlan is not None


-- 
To view, visit https://gerrit.ovirt.org/55892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9825ed7861d7baf68d78b00559909e8a30aad53f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list