Change in vdsm[master]: jsonrpc: make sure not to block when processing i/o
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Apr 11 07:17:06 UTC 2016
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55872/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 857: sock = sslctx.wrapSocket(sock)
Line 858:
Line 859: sock.settimeout(timeout)
Line 860: sock.connect((host, port))
Line 861: sock.setblocking(0)
> If the client side it not running in the reactor thread, then it should be
There is no other code. I just want to be sure that we do not block after being connected.
Line 862: return sock
Line 863:
Line 864:
Line 865: @contextmanager
--
To view, visit https://gerrit.ovirt.org/55872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dee39c7ec518721e809de1cb542173161612ffb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list