Change in vdsm[master]: schedule: Port schedule module to Python 3

nsoffer at redhat.com nsoffer at redhat.com
Mon Apr 11 07:01:58 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: schedule: Port schedule module to Python 3
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/55880/2/lib/vdsm/schedule.py
File lib/vdsm/schedule.py:

Line 211:             self._log.exception("Unhandled exception in %s", self._callable)
Line 212:         finally:
Line 213:             self._callable = _INVALID
Line 214: 
Line 215:     # Rich comparision support (required for Python 3).  This is the minimal
> ... comparison ...
Done
Line 216:     # implementation to allow pushing a call into a heap.
Line 217: 
Line 218:     def __lt__(self, other):
Line 219:         return self._deadline < other._deadline


https://gerrit.ovirt.org/#/c/55880/2/tests/scheduleTests.py
File tests/scheduleTests.py:

Line 230: 
Line 231:     def test_create(self):
Line 232:         call = schedule.ScheduledCall(0, self.callback)
Line 233:         self.assertEqual(0, self.count)
Line 234:         self.assertTrue(call.valid)
> call.valid() ?
Good catch :-)
Line 235: 
Line 236:     def test_execute(self):
Line 237:         call = schedule.ScheduledCall(0, self.callback)
Line 238:         call._execute()


-- 
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d20fe1a1d262d5489be5bedba929709fa59e35
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list