Change in vdsm[master]: mount: Log info message when mounting or unmounting
nsoffer at redhat.com
nsoffer at redhat.com
Sun Apr 10 15:58:38 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/43974/6/vdsm/storage/mount.py
File vdsm/storage/mount.py:
Line 216: return hash((self.__class__, self.fs_spec, self.fs_file))
Line 217:
Line 218: def mount(self, mntOpts=None, vfstype=None, timeout=None, cgroup=None):
Line 219: self.log.info("mounting %s at %s", self.fs_spec, self.fs_file)
Line 220: with utils.stopwatch("%s mounted" % self.fs_file, log=self.log):
> with block in both methods looks very similar. Is there a way to make them
Every line here differ:
- mount vs umount when checking if running as root
- log message
- command arguments
I don't think we should try to abstract things it will only make the code hard to understand.
Line 221: if os.geteuid() != 0:
Line 222: mount = supervdsm.getProxy().mount
Line 223: else:
Line 224: mount = _mount
--
To view, visit https://gerrit.ovirt.org/43974
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc89d6a1bfa0e9d117344d8870d81fed140d03c6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list