Change in vdsm[master]: net tests: give a more legible skip reason

danken at redhat.com danken at redhat.com
Sun Apr 10 06:19:23 UTC 2016


Dan Kenigsberg has uploaded a new change for review.

Change subject: net tests: give a more legible skip reason
......................................................................

net tests: give a more legible skip reason

Current text

    SKIP: ('Tested host is not clean (running vs kernel):\nnetworks: %r != %r\nbonds: %r != %r\n', {}, {}, {}, {u'bond0': {u'nics': [], u'options': u'mode=0'}})

is not formatted.

Change-Id: Id641045f5cfc7e06d6afaf369e25adf021b889f9
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/55902/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 78ea1aa..87590b3 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -105,11 +105,11 @@
         vds.config)
     if ((running_config['networks'] != kernel_config['networks']) or
             (running_config['bonds'] != kernel_config['bonds'])):
-        raise SkipTest("Tested host is not clean (running vs kernel):\n"
-                       "networks: %r != %r\n"
-                       "bonds: %r != %r\n",
-                       running_config['networks'], kernel_config['networks'],
-                       running_config['bonds'], kernel_config['bonds'])
+        raise SkipTest("Tested host is not clean (running vs kernel): "
+                       "networks: %r != %r; "
+                       "bonds: %r != %r",
+                       (running_config['networks'], kernel_config['networks'],
+                       running_config['bonds'], kernel_config['bonds']))
 
     vds.save_config()
     for _ in range(DUMMY_POOL_SIZE):


-- 
To view, visit https://gerrit.ovirt.org/55902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id641045f5cfc7e06d6afaf369e25adf021b889f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list