Change in vdsm[master]: hook: ovs: report ip info on expected top device

phoracek at redhat.com phoracek at redhat.com
Sat Apr 9 21:20:25 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: hook: ovs: report ip info on expected top device
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/55893/2/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 176:         ovs_bonding_caps[bonding] = net_info
Line 177:     return ovs_bonding_caps
Line 178: 
Line 179: 
Line 180: def update_expected_ip_info(caps, running_config):
> as a helper function, please name it with a leading underscore.
Done
Line 181:     """
Line 182:     If a network is marked as bridgeless and untagged, we have to report its IP
Line 183:     info on attached nic/bond.
Line 184:     """


PS2, Line 187: keys
> KEYS
Done


Line 190:             destination[key] = source[key]
Line 191: 
Line 192:     for network, attrs in iter_ovs_nets(running_config.networks):
Line 193:         if not attrs.get('bridged', True) and 'vlan' not in attrs:
Line 194:             bond = attrs.get('bond')
> reminds me a bit of get_engine_expected_top_dev logic...
yup, but here we need type of the device. we can create a function which would return both, but i'd prefer to do some stupid scripting and get back to native ovs.
Line 195:             nic = attrs.get('nic')
Line 196:             if bond is not None:
Line 197:                 copy_net_info(
Line 198:                     caps['networks'][network], caps['bondings'][bond])


-- 
To view, visit https://gerrit.ovirt.org/55893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f124c303a00e7829cb30c51e505c6bcf158cea3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list