Change in vdsm[ovirt-3.6]: hooks: ovs: convert 'bridge' attr to boolean

danken at redhat.com danken at redhat.com
Sat Apr 9 18:04:30 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: convert 'bridge' attr to boolean
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/55890/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

PS1, Line 26: tobool
importing from vdsm in hooks is evil. let's do it as little as we can. please import this bloke from hooking.


-- 
To view, visit https://gerrit.ovirt.org/55890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09eb7c92a2952e18828a3f0f9887b1b2c5457c91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list