Change in vdsm[master]: FakeLVM: Add changeVGTags support

alitke at redhat.com alitke at redhat.com
Fri Apr 8 15:44:09 UTC 2016


Adam Litke has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55703/2/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 188:             raise se.VolumeGroupReplaceTagError("VG %s does not exist" %
Line 189:                                                 vgName)
Line 190: 
Line 191:         # Adding an existing tag or removing a nonexistent tag are ignored
Line 192:         vgTags = set(vg_md['tags'])
> Can you use lower case names?
Done
Line 193:         vgTags |= set(addTags)
Line 194:         vgTags -= set(delTags)
Line 195:         vg_md['tags'] = tuple(vgTags)
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list