Change in vdsm[master]: FakeLVM: Add changeLVTags

alitke at redhat.com alitke at redhat.com
Fri Apr 8 15:42:48 UTC 2016


Adam Litke has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49546/3/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 156:             raise se.LogicalVolumeReplaceTagError("LV %s does not exist",
Line 157:                                                   "%s/%s" % (vg, lv))
Line 158: 
Line 159:         # Adding an existing tag or removing a nonexistent tag are ignored
Line 160:         lvTags = set(lv_md['tags'])
> Can you use lower case names?
Done
Line 161:         lvTags |= set(addTags)
Line 162:         lvTags -= set(delTags)
Line 163:         lv_md['tags'] = tuple(lvTags)
Line 164: 


-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list