Change in vdsm[master]: hsm.py: Deprecate setStoragePoolDescription

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 8 11:00:52 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: hsm.py: Deprecate setStoragePoolDescription
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55858/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1228:         Deprecated, as the storage pool's metadata is no longer persisted.
Line 1229:         When the support for 3.5 clusters is removed, this version can also be
Line 1230:         deleted.
Line 1231:         """
Line 1232:         pass
pass is not needed since we have a docstring:

    def nop():
        """ this does nothing """

Are we expecting such calls from supported engines?

If not, maybe log a warning about using deprecated verb?
Line 1233: 
Line 1234:     @public
Line 1235:     def setVolumeDescription(self, sdUUID, spUUID, imgUUID, volUUID,
Line 1236:                              description, options=None):


-- 
To view, visit https://gerrit.ovirt.org/55858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce0c9f94a13a8b23712055d2bf14b91044058c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list