Change in vdsm[master]: lvm: Remove args hack for activateLVs and deactivateLVs

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 8 09:15:58 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
......................................................................


Patch Set 1: Code-Review-1

Looks good, but can do we really need to support single lv name?

I think we can require an iterable of lvs, and we don't need to protect from people calling with a string, since it will fail in runtime anyway.

We have many calls with list of lvs, and 2 calls with single lv that can be called using [lvname] like the fake storage lib tests.

Using *lvNames, we have to change lot of valid code that called with a list of lvs to use *list.

-- 
To view, visit https://gerrit.ovirt.org/55846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f23f5b21217373bd79abdcfe3d4f8cf233b9e90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list