Change in vdsm[master]: hsm: add untrusted image verification.
nsoffer at redhat.com
nsoffer at redhat.com
Thu Apr 7 13:35:29 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: hsm: add untrusted image verification.
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1514: raise se.ImageVerificationError(
Line 1515: "Uploaded image format is %s while the format specified "
Line 1516: "by the user is %s" % (actual_format, expected_format)
Line 1517: )
Line 1518: if "backingfile" in actual_info:
> I believe thats a relevant scenario that we need to support, if not now so
We don't support it now, and it is not in our todo list.
Line 1519: raise se.ImageVerificationError(
Line 1520: "'%s' is defined as a backingfile, while backingfile is not "
Line 1521: "allowed for an uploaded image."
Line 1522: % actual_info["backingfile"]
--
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list