Change in vdsm[master]: hsm: add untrusted image verification.
nsoffer at redhat.com
nsoffer at redhat.com
Thu Apr 7 13:28:43 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: hsm: add untrusted image verification.
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> I didn't get your comment - we have two "infos" here -
I agree, the error should not mention upload.
Line 1510:
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:
--
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list