Change in vdsm[master]: fileUtils: tarCopy - avoid extracting the file modified time

danken at redhat.com danken at redhat.com
Thu Apr 7 09:35:22 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: fileUtils: tarCopy - avoid extracting the file modified time
......................................................................


fileUtils: tarCopy - avoid extracting the file modified time

We using fileUtils.tarCopy() when there are unsynced clocks between
the source/destination tar might warn us that the source timestamp is
in the future (when we copy from/to file).
This error is logged to stderr, if the copy operation fails for some other
reason the stderr might be flooeded with timestamp in the future warnings
which is confusing when analyzing the cause to the failure.

As we don't care about the timestamp this patch adds the --touch flag
which doesn't extract the file modified date and by that eliminates the
warnings.

Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8
Signed-off-by: Liron Aravot <laravot at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55163
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/fileUtils.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/55163
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list