Change in vdsm[master]: hostdev: add support for hotunplug
fromani at redhat.com
fromani at redhat.com
Thu Apr 7 08:46:40 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: hostdev: add support for hotunplug
......................................................................
Patch Set 13: Code-Review+1
(2 comments)
few questions inside, but looks good enough. Deeper review later.
https://gerrit.ovirt.org/#/c/42747/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS13, Line 2128: for dev in self._devices[hwclass.HOSTDEV][:]:
: if dev.device == dev_name:
: dev_object = dev
: device_objects.append(dev)
: break
question: can we recycle any existing device-find function?
PS13, Line 2144: for dev in self.conf['devices'][:]:
: if (dev['type'] == hwclass.HOSTDEV and
: dev['device'] == dev_object.device):
: dev_spec = dev
: with self._confLock:
: self.c
same question as per line 2132
--
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list