Change in vdsm[master]: hostdev: expose hotplug via vdsClient

fromani at redhat.com fromani at redhat.com
Thu Apr 7 08:00:29 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: expose hotplug via vdsClient
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

I'm ok with everything, but the parsing function looks scary, and I'm afraid it could break. Some tests will easily dispel my concerns.
-1 for visibility/discussion.

https://gerrit.ovirt.org/#/c/54938/11/client/vdsClient.py
File client/vdsClient.py:

PS11, Line 1716: _parseHostdevSpecList
conceptually fine, at glance looks OK, but this code is crying for tests


-- 
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list