Change in vdsm[master]: hooks: Add fcoe hook

danken at redhat.com danken at redhat.com
Wed Apr 6 20:57:15 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add fcoe hook
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/55029/18/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

Line 73: 
Line 74:     config = RunningConfig()
Line 75:     for net, net_attr in six.iteritems(config.networks):
Line 76:         if _has_fcoe_param(net_attr):
Line 77:             if configured[net] is None:
I think you should testif nic is in netattr.

Do not use multiline strings, they are full of spaces.
Line 78:                 hooking.exit_hook("""Failed to configure fcoe
Line 79:                                    on %s with no physical nic""" %
Line 80:                                   (net))
Line 81:             else:


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list