Change in vdsm[master]: tests: Mark integration tests
edwardh at redhat.com
edwardh at redhat.com
Wed Apr 6 15:50:15 UTC 2016
Edward Haas has posted comments on this change.
Change subject: tests: Mark integration tests
......................................................................
Patch Set 5:
(2 comments)
I am not sure if we are in sync about the definition of unit and integration tests.
https://gerrit.ovirt.org/#/c/55730/5/tests/fuserTests.py
File tests/fuserTests.py:
Line 27:
Line 28:
Line 29: class TestFuser(VdsmTestCase):
Line 30:
Line 31: @brokentest("fail on travis")
Braking a test because it is not running on travis?
It looks like an integration tests, it should be mark as such.
Line 32: def testSelfExe(self):
Line 33: pid = os.getpid()
Line 34: with NamedTemporaryFile() as tempFile:
https://gerrit.ovirt.org/#/c/55730/5/tests/utilsTests.py
File tests/utilsTests.py:
Line 283: def testExisting(self):
Line 284: cp = utils.CommandPath('sh', 'utter nonsense', '/bin/sh')
Line 285: self.assertEquals(cp.cmd, '/bin/sh')
Line 286:
Line 287: @brokentest("fail on travis")
Braking a test because it doesn't run on travis?
This test is an integration test: it instantiate a process.
Line 288: def testExistingNotInPaths(self):
Line 289: """Tests if CommandPath can find the executable like the 'which' unix
Line 290: tool"""
Line 291: cp = utils.CommandPath('sh', 'utter nonsense')
--
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list