Change in vdsm[master]: vm: conf: proper locking in migration path

danken at redhat.com danken at redhat.com
Wed Apr 6 12:01:13 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: conf: proper locking in migration path
......................................................................


vm: conf: proper locking in migration path

We are still getting the error
RuntimeError: dictionary changed size during iteration

When calling Vm.status(), especially during migrations,
so we must review our usage of Vm.conf and ensure the lock
is always used.

Change-Id: Ic943e4af2f444f8ffe167175e40a9a2f28afc344
Bug-Url: https://bugzilla.redhat.com/1318550
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54905
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/54905
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic943e4af2f444f8ffe167175e40a9a2f28afc344
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list