Change in vdsm[master]: migration: Add retry on full capacity

fromani at redhat.com fromani at redhat.com
Wed Apr 6 11:13:34 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS25, Line 401: # Differentiate between general migration failure and a retry
> Not sure if I 100% understand your comment. This is part of of the little v
Sure, I know, but it is pretty obvious from the code that we are going to differentiate between a general migration failure and a retry :)

So either please explain in the comment _why_ we should do this differentation, or drop the comment, because it is not adding value *in its current form*.


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list