Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 6 06:37:16 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lvm: Allow multiple initial tags when creating an LV
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

The code change looks good, but I don't understand why it is needed. Please explain the need for this in the commit message.

Also this changes legacy code without tests, and this code can be tested easily by mocking the code running the actual lvm executable, or the lvm executable.

https://gerrit.ovirt.org/#/c/44051/9//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-27 16:13:19 -0400
Line 4: Commit:     Adam Litke <alitke at redhat.com>
Line 5: CommitDate: 2016-04-05 11:53:10 -0400
Line 6: 
Line 7: lvm: Allow multiple initial tags when creating an LV
Please explain why do we need this.
Line 8: 
Line 9: Change-Id: I2524f0127a7cb0eff5d7639b8ba1d916fd66af6a


-- 
To view, visit https://gerrit.ovirt.org/44051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2524f0127a7cb0eff5d7639b8ba1d916fd66af6a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list