Change in vdsm[master]: migration: Add DynamicThrottling semaphores

mbetak at redhat.com mbetak at redhat.com
Tue Apr 5 13:54:10 UTC 2016


Martin Betak has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File lib/vdsm/virt/utils.py:

PS18, Line 123: DynamicBoundedSemaphore
> I cannot and won't insist on this because this is a feeling rather than a t
I have to admit I am complete confused by what you mean by eviction. Once the migration has started (by successful acquisition of the semaphore) there is no way for the Semaphore class itself to reverse this decision - some code has entered a critical section. Only thing you can is to prevent others to enter the same critical sections -> please see my comments at the test.

This is why I find the "Queue" analogy very confusing since this class is really just a semaphore that can have its bound dynamically adjusted.


-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list