Change in vdsm[master]: migration: Add retry on full capacity

fromani at redhat.com fromani at redhat.com
Tue Apr 5 13:14:51 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 23: Code-Review-1

(1 comment)

few comments accumulated, I think a resubmit is needed :\
-1 for visibility.

https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 69: class MigrationLimitExceeded(RuntimeError):
Line 70:     """
Line 71:     Cannot migrate right now: no resources on destination.
Line 72:     """
Line 73:     # FIXME: should subclass MigrationDestinationSetupError?
> Francesco: opinions?
Better not, they are similar but not related, let's keep them separated for the time being. Martin, could you please remove the FIXME?
Line 74: 
Line 75: 
Line 76: class SourceThread(threading.Thread):
Line 77:     """


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list