Change in vdsm[master]: virt: Pass effective guest agent API version during migration
fromani at redhat.com
fromani at redhat.com
Tue Apr 5 11:37:03 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: virt: Pass effective guest agent API version during migration
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
partial ACK: looks good, possible simplification inside
https://gerrit.ovirt.org/#/c/53523/3/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:
PS3, Line 119: None
why not just default to _IMPLICIT_API_VERSION_ZERO?
--
To view, visit https://gerrit.ovirt.org/53523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list