Change in vdsm[master]: vm: conf: proper locking in onDisconnect()

danken at redhat.com danken at redhat.com
Tue Apr 5 10:53:05 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: vm: conf: proper locking in onDisconnect()
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54908/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 873: 
we already assert that this key is in conf, no need to take the lock for adding it.


-- 
To view, visit https://gerrit.ovirt.org/54908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I372e31b7b0d6eb6f8b69871b65e9243ee3ee45a2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list