Change in vdsm[master]: hooks:checkips: add checkips hook

danken at redhat.com danken at redhat.com
Mon Apr 4 13:08:57 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/12/vdsm_hooks/checkips/checkipsd
File vdsm_hooks/checkips/checkipsd:

Line 43:     ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6'
Line 44:     command = [
Line 45:         ping_cmd,
Line 46:         '-c', '1',
Line 47:         '-w', str(PING_TIMEOUT),
> didn't see you comment
regarding -I: it is the responsibility of the user to select a good target host. We should not force the traffic to go via a specific interface.
Line 48:         address
Line 49:     ]
Line 50:     p = subprocess.Popen(
Line 51:         command, stdout=subprocess.PIPE, stderr=subprocess.PIPE


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list