Change in vdsm[master]: virt: recovery: refactor entry points

mpolednik at redhat.com mpolednik at redhat.com
Mon Apr 4 12:01:03 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: recovery: refactor entry points
......................................................................


Patch Set 13: Code-Review-1

(3 comments)

The comments/commit message is too terse to understand. Please add more verbose explanation of what is going and why is it needed.

https://gerrit.ovirt.org/#/c/53819/13//COMMIT_MSG
Commit Message:

PS13, Line 9: to make room for upcoming
            : recovery of containers
I don't understand how this is accomplished in the patch. Please explain further what is this room, why is it needed.


https://gerrit.ovirt.org/#/c/53819/13/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

PS13, Line 165: 3
wait, where is stage 2 now?


PS13, Line 171: def _all_virdomains(cif, doms):
Is this stage 2 now? Needs a comment, this is too chaotic compared to previous version.


-- 
To view, visit https://gerrit.ovirt.org/53819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60cccc642992c7b7a33079a487d0ef27071b8b5
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list