Change in vdsm[master]: hooks:checkips: add checkips hook

alukiano at redhat.com alukiano at redhat.com
Mon Apr 4 08:54:51 UTC 2016


Artyom Lukianov has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd
File vdsm_hooks/checkips/checkipsd:

PS11, Line 64: -I', net,
> Done
mm when I thinking about it now, I think to remove -I parameter not a good idea:
for example, you have two networks each one on different host nic, ping from one nic succeed and from second failed, but interesting me connectivity from the second one, but if I send ping without specifying interface it will try to find the route to address no matter via what interface


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list