Change in vdsm[master]: virt: add device setup and teardown

mpolednik at redhat.com mpolednik at redhat.com
Mon Apr 4 07:48:48 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: add device setup and teardown
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS4, Line 1690: for dev_object in dev_objects[:]
> correct again, but what are we guarding against here?
In this and setup case, the underlying libvirt domain is not even started - hotplug and hotunplug shouldn't be allowed at all. It is really a safety measure in case something touched the devices anyway.


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list