Change in vdsm[master]: events: introduction of schema

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Apr 4 07:22:12 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: events: introduction of schema
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/54754/4/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 81:             raise SchemaNotFound("Unable to find API schema file")
Line 82: 
Line 83:     def get_params(self, class_name, method_name):
Line 84:         return self.get_method('%s.%s' % (class_name,
Line 85:                                           method_name)).get('params', [])
> this get be done separately
Done
Line 86: 
Line 87:     def _trim_subscription_id(self, sub_id):
Line 88:         idx = len(sub_id) - sub_id.rfind('|')
Line 89:         return sub_id[:1 - idx]


-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list