Change in vdsm[master]: hooks:checkips: add checkips hook

danken at redhat.com danken at redhat.com
Mon Apr 4 06:27:19 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd
File vdsm_hooks/checkips/checkipsd:

PS11, Line 64: -I', net,
actually, we should not add the explicit -I argument. The user should choose the target host so that it sits in the subnet range. if the target host is not routeable, there's nothing we can do about it.


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list