Change in vdsm[master]: storagetests: add test for mount.isMounted

ishaby at redhat.com ishaby at redhat.com
Sun Apr 3 12:19:15 UTC 2016


Idan Shaby has posted comments on this change.

Change subject: storagetests: add test for mount.isMounted
......................................................................


Patch Set 5: Verified+1

(4 comments)

https://gerrit.ovirt.org/#/c/55180/4/tests/mountTests.py
File tests/mountTests.py:

Line 303: 
Line 304:     def test_is_mounted(self):
Line 305:         with fake_mounts([b"server:/path "
Line 306:                           b"/rhev/data-center/mnt/server:_path "
Line 307:                           b"nfs4 defaults 0 0"]):
> Use b"..." for all strings here
Done
Line 308:             self.assertTrue(mount.isMounted(
Line 309:                             b"/rhev/data-center/mnt/server:_path"))
Line 310: 
Line 311:     def test_is_not_mounted(self):


Line 305:         with fake_mounts([b"server:/path "
Line 306:                           b"/rhev/data-center/mnt/server:_path "
Line 307:                           b"nfs4 defaults 0 0"]):
Line 308:             self.assertTrue(mount.isMounted(
Line 309:                             b"/rhev/data-center/mnt/server:_path"))
> Use b"..." for all strings here
Done
Line 310: 
Line 311:     def test_is_not_mounted(self):
Line 312:         with fake_mounts([b"server:/path "
Line 313:                           b"/rhev/data-center/mnt/server:_path "


Line 310: 
Line 311:     def test_is_not_mounted(self):
Line 312:         with fake_mounts([b"server:/path "
Line 313:                           b"/rhev/data-center/mnt/server:_path "
Line 314:                           b"nfs4 defaults 0 0"]):
> Use b"..." for all strings here
Done
Line 315:             self.assertFalse(mount.isMounted(


Line 312:         with fake_mounts([b"server:/path "
Line 313:                           b"/rhev/data-center/mnt/server:_path "
Line 314:                           b"nfs4 defaults 0 0"]):
Line 315:             self.assertFalse(mount.isMounted(
Line 316:                              b"/rhev/data-center/mnt/server:_other_path"))
> Use b"..." for all strings here
Done


-- 
To view, visit https://gerrit.ovirt.org/55180
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list