Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example

edwardh at redhat.com edwardh at redhat.com
Sun Apr 3 08:09:18 UTC 2016


Edward Haas has posted comments on this change.

Change subject: test: Replacing MonkeyPatch with mock.patch example
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55603/1/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:

Line 261: 
Line 262:             finally:
Line 263:                 bonds.write('-' + bondName)
Line 264: 
Line 265:     # @MonkeyPatch(bonding, 'BONDING_NAME2NUMERIC_PATH',
The tests pass without these patches.
However, I do not fully understand why the patching is not needed, so until I clarify the 'why', I'm commenting the patch.
Line 266:     #              bonding.BONDING_NAME2NUMERIC_PATH
Line 267:     #              if os.path.exists(bonding.BONDING_NAME2NUMERIC_PATH)
Line 268:     #              else '../vdsm/bonding-name2numeric.json')
Line 269:     def test_get_bonding_option_numeric_val_exists(self):


-- 
To view, visit https://gerrit.ovirt.org/55603
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list