Change in vdsm[master]: net: native ovs [2]: split ovs and legacy networks

edwardh at redhat.com edwardh at redhat.com
Fri Apr 1 18:56:31 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: native ovs [2]: split ovs and legacy networks
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

A few suggestions:
- Canonicalize old ovs marking to the 'switch' attribute in the canonicalize step.
- Put the leftovers in the previous patch.
- Consider adding the rget in a separated patch.

https://gerrit.ovirt.org/#/c/55309/6/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:

PS6, Line 27: tobool(rget(attrs, ('custom', 'ovs')))
I think this logic needs to be handled in the canonicalize step (https://gerrit.ovirt.org/#/c/55495).


Line 27:     return tobool(rget(attrs, ('custom', 'ovs')))
Line 28: 
Line 29: 
Line 30: def is_ovs_bond(attrs):
Line 31:     attrs_d = dict(option.split("=", 1)
Same here
Line 32:                    for option in attrs.get('options', '').split())
Line 33:     return attrs_d.get('custom') == 'ovs'
Line 34: 
Line 35: 


-- 
To view, visit https://gerrit.ovirt.org/55309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib78057445c38da542450b4ab8d79ea049a9c17f1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list