Change in vdsm[ovirt-3.6]: storage: fix disconnecting multiple iSCSI sessions

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 1 16:34:42 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: fix disconnecting multiple iSCSI sessions
......................................................................


Patch Set 1:

(3 comments)

Thanks Pavel!

Please post again to master, I cannot access the master version mentioned on the bug.

Better backport after the master patch is merged, since gerrit adds important metadata when merging.

https://gerrit.ovirt.org/#/c/55577/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: storage: fix disconnecting multiple iSCSI sessions
Line 8: 
Line 9: An iSCSI connection can have multiple session. It's necessary to
Line 10: disconnect all related sessions.
Can you explain in the commit message why we need multiple session, and mention some number if you measured the performance of this setup.
Line 11: 
Line 12: Bug-Url: https://bugzilla.redhat.com/1322933
Line 13: Change-Id: I9f82c1f882afcfc3840b6d7ade0d74ac940b4d96


https://gerrit.ovirt.org/#/c/55577/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 547:         if self._cred != cred:
Line 548:             raise self.Mismatch("cred mismatch")
Line 549: 
Line 550:     def getSessionIds(self):
Line 551:         sids = []
Better use a set() because the order if the ids does not matter, and this will allow comparing set of sessions in __eq__.
Line 552:         errors = []
Line 553:         for session in iscsi.iterateIscsiSessions():
Line 554:             try:
Line 555:                 self._match(session)


Line 593: 
Line 594:         try:
Line 595:             mySids = self.getSessionIds()
Line 596:             hidSids = other.getSessionIds()
Line 597:             return mySids == hisSids
This will not work if the order of the ids is different.
Line 598:         except OSError:
Line 599:             pass
Line 600: 
Line 601:         return hash(self) == hash(other)


-- 
To view, visit https://gerrit.ovirt.org/55577
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f82c1f882afcfc3840b6d7ade0d74ac940b4d96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Pavel Gashev <pax at acronis.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list