Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
osvoboda at redhat.com
osvoboda at redhat.com
Tue Sep 29 16:43:30 UTC 2015
Ondřej Svoboda has posted comments on this change.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/45112/7/tests/netinfoTests.py
File tests/netinfoTests.py:
Line 499: del netdict['iface']
Line 500:
Line 501: def _add_vnet0():
Line 502: for network, netdict in FAKE_NETINFO['networks'].iteritems():
Line 503: if netdict['bridged']:
> in this point, all networks are bridged, arent they?
Good point, they are. Honestly, I don't know if I only forgot about removing the condition...
Anyway, I'd even vote to keep the code as is, for two reasons:
– First, I'd prefer to have bottom patches from this topic merged rather than having to maintain the topic continuously. By changing this patch I would either have to rebase others sitting on top of it or end up with patches that are not in a single line here on Gerrit (which is true even now – some patches point to older versions of other patches).
– Second, the condition serves as self-documentation, which is code trait I like to have.
Line 504: netdict['ports'].append('vnet0')
Line 505: netdict[EXPECTED_NICS].append('vnet0')
Line 506:
Line 507: _test()
--
To view, visit https://gerrit.ovirt.org/45112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list