Change in vdsm[master]: ssl: runtime config to choose implementation

fromani at redhat.com fromani at redhat.com
Tue Sep 29 15:17:18 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/44689/12/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:

Line 21: 
Line 22: if config.get('vars', 'ssl_implementation') == 'm2c':
Line 23:     from . import m2cutils as sslutils
Line 24:     from .m2cutils import SSLHandshakeDispatcher
Line 25:     from .m2cutils import SSLSocket
this specific change (import order swap) belongs in the parent patch.
Line 26: else:
Line 27:     from . import sslutils
Line 28:     from .sslutils import SSLHandshakeDispatcher
Line 29:     from ssl import SSLSocket


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list