Change in vdsm[master]: host stats: Collect stats from online cpu cores only
rmohr at redhat.com
rmohr at redhat.com
Tue Sep 29 09:26:57 UTC 2015
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 693: for cpu_core in cpu_cores:
Line 694: # Do not try to collect cpu core data when no samples are present
Line 695: if (not last_sample.cpuCores.getCoreSample(cpu_core) or not
Line 696: first_sample.cpuCores.getCoreSample(cpu_core)):
Line 697: continue
> Yes, but I'm under the impression that we are supposed to have samples for
> Besides that, why you'd like to avoid exceptions? code style, code clarity, performance, something else?
Hm, I could definitely increase the readability. Maybe I should rewrite it:
if _samples_exist(first_sample, last_sample, cpu_core):
add samples
Why shouldn't I just check if my samples are there if I can?
It is much safer than relying on an exception which is delegated through X levels (Yes, just two level here and the method is a helper method just for this context, but still ...) and you don't catch something you didn't want to catch. And in my eyes it is more meaningful.
Line 698: core_stat = {
Line 699: 'nodeIndex': int(node_index),
Line 700: 'cpuUser': compute_cpu_usage(cpu_core, 'user'),
Line 701: 'cpuSys': compute_cpu_usage(cpu_core, 'sys'),
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list