Change in vdsm[master]: network: Inexistence of a network in libvirt should not be f...

osvoboda at redhat.com osvoboda at redhat.com
Mon Sep 28 23:07:15 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: network: Inexistence of a network in libvirt should not be fatal to us
......................................................................


Patch Set 2:

(1 comment)

A forgotten comment prior to abandoning.

https://gerrit.ovirt.org/#/c/34988/2/vdsm/network/api.py
File vdsm/network/api.py:

Line 741:                 logger.debug('Removing broken network %r', network)
Line 742:                 _delBrokenNetwork(network, libvirt_nets[network],
Line 743:                                   configurator=configurator)
Line 744:                 _netinfo.updateDevices()
Line 745:             elif 'remove' in attrs:
Depending on options['_inRollback'] we could warn or raise the former exception.
Line 746:                 logger.warning("Not deleting network {0!r}: it is unknown to "
Line 747:                                "libvirtd".format(network))
Line 748:                 del networks[network]
Line 749:             else:


-- 
To view, visit https://gerrit.ovirt.org/34988
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ae4b359d543b6e3ee560a5cb021e31d037c035
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list