Change in vdsm[master]: tests: Improve utils.retry tests

danken at redhat.com danken at redhat.com
Sun Sep 27 19:33:31 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: tests: Improve utils.retry tests
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46399/4/tests/utilsTests.py
File tests/utilsTests.py:

Line 100:         # Make sure we had the proper amount of iterations before failing
Line 101:         self.assertEquals(counter[0], limit)
Line 102: 
Line 103:     @brokentest("deadline is not respected")
Line 104:     def testTimeoutDeadlineReached(self):
Nir, I don't understand the broken condition. Are you referring to us not using ">=" in

 ((monotonic_time() - startTime) > timeout)

?
Line 105:         # time  action
Line 106:         # 0     first attempt
Line 107:         # 1     sleep
Line 108:         # 2     second attempt


-- 
To view, visit https://gerrit.ovirt.org/46399
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62062f36e20d263b1aed64135345d496cb7cfd61
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh.dev at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list