Change in vdsm[master]: ssl: ssl socket may throw sslerror during reading

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Sep 25 19:09:40 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: ssl: ssl socket may throw sslerror during reading
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46625/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 127:             else:
Line 128:                 raise
Line 129:         except SSL.SSLError as e:
Line 130:             self.log.error('SSL error during reading data: %s', e)
Line 131:             self.handle_close()
> You should return '' here, see the other branches.
Done
Line 132: 
Line 133:     def send(self, data):
Line 134:         try:
Line 135:             result = self.socket.send(data)


-- 
To view, visit https://gerrit.ovirt.org/46625
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list