Change in vdsm[master]: dispatcher: improve failure logging

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 24 08:43:30 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: dispatcher: improve failure logging
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/46624/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 45
Line 46
Line 47
Line 48
Line 49
In the original asyncore design, all errors are handled by calling handle_error, so logging errors there should be enough.

I'm not sure if this is true for better-asyncore though.


-- 
To view, visit https://gerrit.ovirt.org/46624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93d993909a5b42650265d6cf0d0e811d4e98f2b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list