Change in vdsm[master]: move _kill_and_rm_pid to utils

phoracek at redhat.com phoracek at redhat.com
Thu Sep 24 07:58:56 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: move _kill_and_rm_pid to utils
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45527/3/vdsm/network/configurators/dhclient.py
File vdsm/network/configurators/dhclient.py:

Line 26: 
Line 27: from vdsm import cmdutils
Line 28: from vdsm import ipwrapper
Line 29: from vdsm import netinfo
Line 30: from vdsm.utils import (CommandPath, execCmd, memoized, pgrep, kill_and_rm_pid)
no need for parentheses
Line 31: 
Line 32: DHCLIENT_CGROUP = 'vdsm-dhclient'
Line 33: LEASE_DIR = '/var/lib/dhclient'
Line 34: LEASE_FILE = os.path.join(LEASE_DIR, 'dhclient{0}--{1}.lease')


-- 
To view, visit https://gerrit.ovirt.org/45527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia459c02b63123dda081122a72b2517219978fc12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list