Change in vdsm[master]: ImageManifest: introduce ImageManifest class

nsoffer at redhat.com nsoffer at redhat.com
Wed Sep 23 20:13:08 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ImageManifest: introduce ImageManifest class
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/43551/12/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:

Line 283: 
Line 284: 
Line 285: class FakeImageManifest(image.ImageManifest):
Line 286:     def __init__(self):
Line 287:         self.repoPath = '/rhev/data-center'
> The redirection target always needs to be faked because we pass bogus param
I don't mean the entire class, only the way you initialize the repoPath, but this is not important for redirection tests, and consistent with other class here, so lets keep it as is.
Line 288: 
Line 289:     @recorded
Line 290:     def getImageDir(self, sdUUID, imgUUID):
Line 291:         pass


-- 
To view, visit https://gerrit.ovirt.org/43551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a78aef10902b9baf6f88d2e053e2232e2a1267
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list