Change in vdsm[master]: hostdev: change ownership for passthrough USB devices

fromani at redhat.com fromani at redhat.com
Tue Sep 22 11:02:23 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: change ownership for passthrough USB devices
......................................................................


Patch Set 19: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/44679/19/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 398:                 'ATTRS{{devnum}}=="{}", OWNER:="{}", GROUP:="{}"\n').format(
Line 399:                     bus, device, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP)
Line 400: 
Line 401:         with open(rule_file, "w") as rf:
Line 402:             self.log.debug("Creating rule %s: %r", rule_file, rule)
minor: why not just before the with: block?
Line 403:             rf.write(rule)
Line 404: 
Line 405:         self._udevTrigger(attr_matches=(('busnum', int(bus)),
Line 406:                                         ('devnum', int(device))))


-- 
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f72f63186187254cd4aded0a2e6c396001ca28b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list