Change in vdsm[master]: caps: raise if bridge has more than one port
danken at redhat.com
danken at redhat.com
Tue Sep 22 09:06:55 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: caps: raise if bridge has more than one port
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46321/3/vdsm/caps.py
File vdsm/caps.py:
Line 100: continue
Line 101: if len(host_ports) == 1:
Line 102: iface = host_ports[0]
Line 103: else:
Line 104: raise RuntimeError('bridge with more than one port')
a more useful log would list the name of the offending bridge and its ports.
Line 105:
Line 106: if iface in caps['vlans']:
Line 107: vlan_id = caps['vlans'][iface]['vlanid']
Line 108: iface = caps['vlans'][iface]['iface']
--
To view, visit https://gerrit.ovirt.org/46321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20d4b8b6e3147a29aebcbc7a68b9c92d23aa4307
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list