Change in vdsm[master]: network: add ifcfg write hook correction

ibarkan at redhat.com ibarkan at redhat.com
Tue Sep 22 06:01:32 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: add ifcfg write hook correction
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46476/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 548:                 logging.debug('ignoring variable %s', k)
Line 549: 
Line 550:         ifcfg_file = netinfo.NET_CONF_PREF + name
Line 551:         hook_dict = {'ifcfg_file': ifcfg_file,
Line 552:                      'config': cfg}
vdsm/vdsmd.8.in should be updated accordingly
Line 553:         hook_return = hooks.before_ifcfg_write(hook_dict)
Line 554:         cfg = hook_return['config']
Line 555:         self.writeConfFile(ifcfg_file, cfg)
Line 556:         hooks.after_ifcfg_write(hook_return)


-- 
To view, visit https://gerrit.ovirt.org/46476
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c7a14e45f3b650f4677ff4c78fe662c73ea2ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list