Change in vdsm[master]: ssl: runtime config to choose implementation

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Sep 21 07:52:41 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:

Line 29:         from . import m2cutils as sslutils
Line 30:         from .m2cutils import SSLSocket
Line 31:         from .m2cutils import SSLHandshakeDispatcher
Line 32:         _USED_M2C = True
Line 33:     except ImportError:
> use m2crypto as default and add a check in vdsm/vdsm that if we run over de
OK. it would be better than falling back like we did.
Line 34:         _log.warning('Configured m2crypto but not available falling back'
Line 35:                      ' to ssl')
Line 36:     else:
Line 37:         # we need it to satisfy pyflakes


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list