Change in vdsm[master]: ssl: configurable implementation

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 21 07:36:32 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: configurable implementation
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in
File vdsm.spec.in:

Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py*
Line 1073: %if %{with_m2c}
Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1076: %else
> OK, during the build or during installation we can do it. In my opinion tha
why? there are places in code that we check if something installed and if not we fallback to another implementation. its quite common, and here, if user configures vdsm to use m2crypto and its not exist, vdsm will fail to start with an error saying to install the package - sounds perfectly reasonable to me.
Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1079: %endif
Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py*


-- 
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list