Change in vdsm[master]: ssl: configurable implementation

ybronhei at redhat.com ybronhei at redhat.com
Sun Sep 20 14:16:41 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: configurable implementation
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/44494/10/vdsm.spec.in
File vdsm.spec.in:

Line 1072: %{python_sitelib}/%{vdsm_name}/sslcompat.py*
Line 1073: %if %{with_m2c}
Line 1074: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1075: %exclude %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1076: %else
> Yaniv, we cannot ship vdsm on debian using m2c, since our code is not compa
what is shipping? having a py file as part of the installation? alert the user that over debian he must config 1 2 3 otherwise default ssl implementation will cause failures. if you want you can add "check code" in vdsm/vdsm to validate that if debian is the os and m2crypto is configured, alert and exit.
Line 1077: %exclude %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1078: %{python_sitelib}/%{vdsm_name}/sslutils.py*
Line 1079: %endif
Line 1080: %{python_sitelib}/%{vdsm_name}/supervdsm.py*


-- 
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list